Re: [PATCH] Addition Of http-proxy-port-exceptions
Jonathan Houser <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
Stipe,
> ok, first of all thanks for submitting the patch. I'm +0 on this, in the
> current version.
>
> The reason is: As this is an add-on to the existing
> 'http-proxy-exceptions' config directive, which contains hostnames that
> are avoided to be proxied, and actually both, the old and your new
> config directive yield to a binary decission: yes, proxy, or no, do not
> proxy -- how about using regex expressions here in a single config
> directive?
>
> I'm not quite sure about how, but I suppose this should be fairly
> possible, in the regex notation that '<scheme>://<hostname>:<port>'
> identifies a request target.
>
> So you may obviosly "block" any proxying via specifying a regex
> expression that starts with "https" and leaves the hostname and port
> open. Others could explicetly block proxying ot specific ports or
> hostnames, etc.
>
> IMO, this regex config directive would be actually more powerfull in
> terms of "reducing" the necessary steps to add some specific rules for
> proxying?!
I had actually considered the regex approach looking for
"https://" as well. I think I went with the one I did mainly because it
seemed less intrusive (thus less likely to break other people's config
files) than the patch I submitted. I'll happily look into the regex
approach if that's what you'd rather have.
Jon