Re: Character Set Question (WAP)

>>>> This is with a GSM handset so you may be able to test and get the 
>>>> same results.  I found the Character Set being sent via tcpdump and 
>>>> ethereal as it's not listed in the debug output from Kannel.
>>>
>>>     Looks like it's the Character Set in the <?xml section (ie. 
>>> encoding=) that's causing the problem.  I checked the code and 
>>> stumbled across a TODO.  Guess I'll look into DOing it.  Thanks.
>>
>> Looks that you're one of a few people who actually using kannel as a
>> wap gateway, not as smsrouter.
>> Take a look at my patchset. It worth it. In particular, almost all of
>> charset problems are solved here.
> 
> Paul, I have commented already your patch, right? Can you please outline 
> again why you things are done here (with your patch) the right way?!

      Thanks to Dermot and Paul for their feedback.  I actually made a 
patch that fixes my issue with a lot less code changes than what Paul 
had submitted.  Essentially the issue was that the charset was being 
changed, but the actual low-level compiler didn't know this and instead 
used the charset defined in the <?xml...encoding=... block.  All I did 
was add a flag, "was_converted", to the content struct.  I then set it 
to 1 if it's been converted, and use it in the compiler itself to see 
that it should prefer the passed in charset over the one in the <?xml 
block.  Simple fix.  Works for me.  I'm going to have to back out my 
changes for the other patch (http-proxy-port-exceptions) if the core 
developers feel I should.  Then I'll submit this patch and re-code the 
fix for my other issue.

Jon