Re: [PATCH] Charset generalization - take 1
Jonathan Houser <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
Paul,
> Well, I did something. It survives only basic testing, and of course
> not complete yet, but I'll post it here - maybe someone will say
> something.
I just went through it and it looks very nice indeed. You
centralized a lot of code that got called over and over before, and made
the 'compiling' a lot more straightforward. I'm going to give it a shot
(unless you're not ready for that yet) and see if it fixes the problems
I was having. I'm sure it probably will. Excellent work. :)
> P.S. add octstr_destroy(charset) at the end of normalize manually :)
But why? Then there won't be a memory leak anymore... <sob> :P
Jon