Re: [PATCH] Charset generalization - take 1

Paul P Komkoff Jr <[email protected]>
Newsgroups gmane.comp.mobile.kannel.devel
Organization Department of Fish & Wildlife
Message-ID <[email protected]>
Replying to Jonathan Houser:
>      I just went through it and it looks very nice indeed.  You 
> centralized a lot of code that got called over and over before, and made 
> the 'compiling' a lot more straightforward.  I'm going to give it a shot 
> (unless you're not ready for that yet) and see if it fixes the problems 
> I was having.  I'm sure it probably will.  Excellent work.  :)

There are still things left to test. For example, when I pass encoding
to xmlReadMemory and xml source have <?xml> preamble with different
encoding specified, which will prevail? For our cause, it will be
better if the former will be preferred. But in reality I need to
consult libxml2 source code :)

I have this thing online for testing and it works for some sites with
my phone (nokia 6310i), but for extensive testing I'll try to put it
online to production :)

> >P.S. add octstr_destroy(charset) at the end of normalize manually :)
> 
>      But why?  Then there won't be a memory leak anymore...  <sob>  :P

Don't worry,I'll put it somewhere else :)

-- 
Paul P 'Stingray' Komkoff Jr // http://stingr.net/key <- my pgp key
 This message represents the official view of the voices in my head
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.