Re: Patch to resolve out of order messages on retry to smsbox

Hi,

the first question is, why retry heppens? smsbox crashed?
As to the patch: this patch will not work as expected. It's intentinally  
that we put message at the end of the queue because we want to go through  
the whole queue. I don't see how it should work with your patch.


Am 02.11.2006, 10:59 Uhr, schrieb Ben Suffolk <[email protected]>:

> For a little context see this extract from a message I sent to the
> user list :
>
>> What I thought was more interesting from my test was that I
>> received the messages out of order from when they were sent, I sent
>> 1,2,3,4 and actually received 2,3,4,1 at smsbx. For me this could
>> be a real issue as order of messages from users is important to me
>> (they build up a command, as opposed to being one-shot). Is there
>> anyway to stop bearerbox reordering the messages?
>
> I investigated what was causing this and saw that once every 60
> seconds the messages got re-tried for smsbox routing. Looking in
> sms_to_smsboxes() in bb_boxc.c I could see that the first message was
> being looped to the back to the list, so every 60 seconds the first
> message was moved to be the last message.
>
> This patch fixes the issue, so the list order is preserved.
>
> Regards
>
> Ben
>



-- 
Thanks,
Alex