Re: [PATCH] Fix a core dump with AT2 SMSC and lost network connections in rawtcp mode

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ben Suffolk wrote:
> Hi all,
> 
> I have 4 modems connected via rawtcp mode to a terminal server.
> 
> I discovered that if I reboot the terminal server (or presumably 
> otherwise have a network connection failure) that bearerbox core dumps.
> 
> The following patch fixes this problem.

Hi Ben,

thanks a lot for the patch, +1 from me and commited to CVS HEAD:

2007-05-20  Stipe Tolj  <stolj at kannel.org>
   * gw/smsc/smsc_at.c: fix a possible segfault while read()ing on the device
     file descriptor. Thanks to Ben Suffolk <[email protected]> for the patch.
     [Msg-Id: <[email protected]>]

(with slight modification, since read() is allowed to return 0 without
interpreting it as error.)

Another kind request for next patchsets, please provide in 'diff -u' format,
which is more readable ;) ... Thanks again! Keep on the good work!

Stipe

- -------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture      Kannel Software Foundation (KSF)
http://www.tolj.org/              http://www.kannel.org/

mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
- -------------------------------------------------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGUHO19ez0oeKvYs0RAig1AKCz9aK0baJmLpzHVWktpNdQ+Kmr7gCeMybI
kFn1ffuq6+2ur0ut1/boLk4=
=nwqq
-----END PGP SIGNATURE-----