Re: [PATCH] Fix a core dump with AT2 SMSC and lost network connections in rawtcp mode

Cheers,

Sorry about the diff not diff -u, I thought it looked a bit different  
than when I normally create diffs, must have been a bad day :-)

I did think about read() being able to return 0, but in theory it  
never should since we have done a select() just above it. It thats  
returns to say that there is data read to read then in my book if it  
does not read it something is wrong.

Regards

Ben


On 20 May 2007, at 17:13, Stipe Tolj wrote:

> Hi Ben,
>
> thanks a lot for the patch, +1 from me and commited to CVS HEAD:
>
> 2007-05-20  Stipe Tolj  <stolj at kannel.org>
>    * gw/smsc/smsc_at.c: fix a possible segfault while read()ing on  
> the device
>      file descriptor. Thanks to Ben Suffolk <[email protected]> for  
> the patch.
>      [Msg-Id: <[email protected]>]
>
> (with slight modification, since read() is allowed to return 0 without
> interpreting it as error.)
>
> Another kind request for next patchsets, please provide in 'diff - 
> u' format,
> which is more readable ;) ... Thanks again! Keep on the good work!
>
> Stipe