Re: [PATCH] Re: Bug: extract_msgdata_part_by_coding / message split

ok, commited to cvs.

Stipe Tolj wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Alexander Malysh wrote:
> 
>> Hi,
>> 
>> why it should be necessary now? we have utf-8 internally and you can send
>> any gsm-03.38 chars via smsbox.
> 
> yep, +1, confirmed... my ChangeLog at that time:
> 
> 2006-09-29  Stipe Tolj  <stolj at kannel.org>
>     * gw/smsc/smsc_fake.c: add TODO comment to add a SMPP DLR payload text
>       for a DLR returned back via fake module.
>     * gw/smsc/smsc_smpp.c: obey charset more closely in msg_to_pdu(),
>     where
>       we don't call charset_latin1_to_gsm() if charset flag of msg struct
>       carries the "GSM-03.38" indication. This is not yet used by smsbox,
>       but may be used by external modules before we have a clean
>       transition to UTF-8 as internal charset and target charset
>       indication via msg struct's charset value. Also ensures now that we
>       write a "FAILED DLR SMS" access-log entry if we receive a DLR, but
>       can't find it via handle_dlr().
> 
> which makes clear that we don't need it anymore... need to remove it.
> 
> Stipe
> 
> - -------------------------------------------------------------------
> Kölner Landstrasse 419
> 40589 DÃŒsseldorf, NRW, Germany
> 
> tolj.org system architecture      Kannel Software Foundation (KSF)
> http://www.tolj.org/              http://www.kannel.org/
> 
> mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
> - -------------------------------------------------------------------
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.7 (MingW32)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iD8DBQFGX/9H9ez0oeKvYs0RAssIAKC0H+kOwyIKb9J37NWoXwJ/UTWxjACfeexY
> CU19w+VO0E40ZBI6rNM1sr8=
> =J9WL
> -----END PGP SIGNATURE-----

-- 
Thanks,
Alex