Re: [PATCH] wapbox SSL config loads

Vincent CHAVANIS schrieb:
> Hi all,
> 
> Is there any reasons why we load ssl config
> into wapbox without checking if we HAVE_LIBSSL ?
> We do not want to load unused variables.
> here is a patch that fix this.
> 
> any comments ?
> 
> Vincent.
> 
> 
> diff -rauw /gateway-cvs/gw/wapbox.c /gateway/gw/wapbox.c
> --- /gateway-cvs/gw/wapbox.c    2008-01-09 21:06:57.000000000 +0100
> +++ /gateway/gw/wapbox.c        2008-03-20 18:45:34.000000000 +0100
> @@ -147,7 +147,9 @@
>     /* load parameters that could be later reloaded */
>     config_reload(0);
>     +#ifdef HAVE_LIBSSL
>     conn_config_ssl(grp);
> +#endif /* HAVE_LIBSSL */
> 
>     /*
>      * And the rest of the pull info comes from the wapbox group.

-1, the patch is not required. Why? Follow the 'conn_config_ssl()' call, and you 
see:

...
void conn_config_ssl (CfgGroup *grp)
{
     info(0, "SSL not supported, no SSL initialization done.");
}
#endif /* HAVE_LIBSSL */

which means we have this already covered in the #else branch to inform the user 
we didn't do any SSL init, since no support is compiled in.

;)

Stipe

-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture      Kannel Software Foundation (KSF)
http://www.tolj.org/              http://www.kannel.org/

mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------