Re: sms-rate-refresh feature

Hi,

no objections -> commited to cvs.

Alexander Malysh schrieb:
> Hi,
> 
> too much time passed since this post, but thanks to Stipe who pointed me 
> to this post.
> 
> Attached is a patch that implements simple bandwidth meter with 
> heuristic and needed changes to bearerbox status.
> 
> Bearerbox status show now 3 speeds: 1 minute sample, 5 minute sample, 
> and over livetime.
> 
> Example:
> SMS: inbound (0.00,0.00,0.00) msg/sec, outbound (0.00,0.00,0.00) msg/sec
> 
> Comments please...
> 
> Thanks,
> Alex
> 
> Alexander Malysh schrieb:
>> Hi,
>>
>> I already implemented this in my tree, just give me some time to extract
>> this...
>>
>> Rafael Alfaro wrote:
>>
>>> Hello Alex,
>>>
>>> First of all, thanks  for your time,
>>> Could you explain me a little bit about: "Simple bandwidth meter 
>>> should do
>>> it"? How is the best way to implement this?
>>>
>>> Thanks in advance.
>>>
>>> Rafael Alfaro.
>>>
>>> On Tue, Mar 25, 2008 at 4:06 AM, Alexander Malysh <[email protected]>
>>> wrote:
>>>> Hi Rafael,
>>>>
>>>>  -1 for this patch. You don't need yet another thread to do this. 
>>>> Simple
>>>>  bandwidth meter should do it...
>>>>
>>>>
>>>>  Rafael Alfaro wrote:
>>>>
>>>>  > Hello Everybody,
>>>>  >
>>>>  > I did this patch with the following purpose:
>>>>  > Provide the bearerbox status web page with an online incoming and
>>>>  > outgoing sms rate display (msg/sec).
>>>>  >
>>>>  > For example, if you take a look to the current bearerbox status web
>>>>  > page, you will see that the sms rate is the average since the
>>>>  > bearerbox is online, because the current code is:
>>>>  >
>>>>  >         (float) counter_value(incoming_sms_counter)/t,
>>>>  >         (float) counter_value(outgoing_sms_counter)/t,
>>>>  >
>>>>  > So, I added a new feature to the core group cfg: "sms-rate-refresh".
>>>>  > This will launch a thread that will be sampling the
>>>>  > "counter_value(incoming_sms_counter)" and
>>>>  > "counter_value(outgoing_sms_counter)" every "sms_rate_refresh"
>>>>  > seconds, and with this information we can calculate the current sms
>>>>  > rate (msg/sec).
>>>>  >
>>>>  > If the "sms-rate-refresh" feature is not used at the configuration
>>>>  > file, by default, the average since bearerbox is online will be
>>>>  > displayed (like right now is coded).
>>>>  >
>>>>  > Best Regards,
>>>>
>>>>  --
>>>>  Thanks,
>>>>  Alex
>>>>
>>>>
>>>>
>>
>