Re: SMPP Patch for data_coding: 3

Michael Zervakis schrieb:
> Dear all,
> 
>    We connect to a SMPP SMSC using kannel and we had problems reading
> greek characters when data coding was set to 3. I attached the
> modifications to gw/smsc/smsc_smpp.c that solved the problem.

-1 for the patch.

DCS=0x03 is defined in SMPP v3.4 to be ISO-8859-1 (latin1) and you want to call

  charset_gsm_to_utf8(msg->sms.msgdata);

there which assumes that the msg->sms.msgdata is GSM 03.38 encoded, but this is
NOT ALLOWED according to the protocol if data_coding is set to 3.

This breaks the transcoding chain.

This means: if your SMPP SMSC is sending you a deliver_sm PDU with data_coding =
3 AND GSM 03.38 encoded payload, it is not acting according to the spec. ;)

Can you confirm which SMSC vendor this is?

You should also note that the latin1 table has NO greek chars included, see

  http://en.wikipedia.org/wiki/ISO_8859-1

the ISO-8859-7 is the subset that DOES include the greek chars, see

  http://en.wikipedia.org/wiki/ISO/IEC_8859-7

but this is not explicitly defined with an own DCS value in SMPP. Therefore most
SMSCs use the GSM 03.38 encoding (which includes greek chars) as DCS=0x00 value.

Stipe

-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture      Kannel Software Foundation (KSF)
http://www.tolj.org/              http://www.kannel.org/

mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------