Re: [PATCH] Location header recovering to absoluteURI

Hi,

some comments to patch:

+        /* port, only added if literally not default. */
+        if (trans->port != 80) {
+            octstr_format_append(os, ":%ld", trans->port);
+        }

I don't think this is needed, just always add port to URI.


+         * Some HTTP servers 'interpret' a leading UDI / as that kind
						    ^^^ URI??
+         * of absoluteURI, which is not correct, following the protocol

Otherwise patch look ok, +1 from me.

Thanks,
Alex

Stipe Tolj schrieb:
> Alejandro Guerrieri schrieb:
>> Apart from renaming "absulte" to "absolute", patch looks fine and I'm +1
>> with the idea of allowing this behavior.
> 
> ehmmm ;) ... yep right, here we go with the typo fixed.
> 
> Stipe
> 
>