Re: [PATCH] Location header recovering to absoluteURI

Alexander Malysh schrieb:
> Hi,
> 
> some comments to patch:
> 
> +        /* port, only added if literally not default. */
> +        if (trans->port != 80) {
> +            octstr_format_append(os, ":%ld", trans->port);
> +        }
> 
> I don't think this is needed, just always add port to URI.

yep, but I have speed in mind here. The octstr_format_append() is "expensiver"
in terms of CPU cycles then a simple long compare in the if statement. And we
also don't need to "parse" it again in the next integration. That's why.

> Otherwise patch look ok, +1 from me.

ok, going to commit.

Thanks Alejandro and Alex for reviewing.
Stipe

-- 
-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

tolj.org system architecture      Kannel Software Foundation (KSF)
http://www.tolj.org/              http://www.kannel.org/

mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------