Re: [PATCH] utils/mtbatch.c DLR support patch

Hi Vincent,

some comments to your patch:

+
+        if (dlr_mask > 0 && dlr_url) {
+            msg->sms.dlr_mask = dlr_mask;
+            msg->sms.dlr_url = octstr_duplicate(dlr_url);
+        }

don't check this for each message, check this once by start and please  
use dlr macros:
DLR_IS_ENABLED(dlr_mask)

              case 'f':
                  from = octstr_create(optarg);
                  break;
+
+            case 'D':
+                dlr_mask = atoi(optarg);

please kill extra line

+    if (dlr_mask && dlr_url == NULL)
+        panic(0,"dlr-url address not specified. Use option -D to  
specify dlr-url address.");
+

should be if ((DLR_IS_ENABLED(dlr_mask) && dlr_url == NULL) || (! 
DLR_IS_ENABLED(dlr_mask) && dlr_url != NULL)

Thanks,
Alex

Am 07.04.2009 um 12:53 schrieb Vincent CHAVANIS:

>
> This patch add a DLR support for mtbatch.
> Will try to provide the charset/udh patch soon
>
> Vincent.
>
>
> -- 
> Telemaque - 06560 SOPHIA-ANTIPOLIS - (FR)
> Service Technique/Reseau - NOC
> Direction du Developpement xMS+
> http://www.telemaque.fr/
> [email protected]
> Tel : +33 4 92 90 99 84 (fax 9142)
> <mtbatchv4.txt>