Re: Patch: smsc_smpp.c

Hi,

I don't see a reason to keep these variables bundled. ton is more frequently changed. npi almost never does. They mean different things, and are independent of each other. Why not give user the choice to set whatever they need in configuration? Same holds for source-addr-ton & npi.

I think it makes more sense to patch the source. In either case if you decide to go with the guide, I can submit that as well. One of the two has to be patche, though.

BR,
Nikos
  ----- Original Message ----- 
  From: Alexander Malysh 
  To: Nikos Balkanas 
  Cc: [email protected] 
  Sent: Monday, November 09, 2009 11:32 AM
  Subject: Re: Patch: smsc_smpp.c


  Hi,


  I don't see reason to apply this patch. User can just define ton and npi settings. Maybe userguide patch
  would be more helpful?


  Thanks,
  Alexander Malysh


  Am 02.11.2009 um 12:31 schrieb Nikos Balkanas:


    Hi,

    This is another one in my series of trivial patches. This part of the configuration has caused a lot of confusion in manual configuring dest-addr-ton over the years, with users prefixing their numbers with '+' instead of using the configuration.

    BR,
    Nikos
    <smsc_smpp.diff>