Re: [PATCH] Kannel SMPP v5.0 support

Am 08.10.2012 20:39, schrieb Stipe Tolj:
> Hi list,
>
> please find attached a patchset that adds all the relevant new PDUs and
> optional TLVs as defined in SMPP v5.0. The diff is against current SVN
> trunk.
>
> Some facts about the patch:
>
> - We add the missing PDUs as defined in SMPP v5.0, even while we're
> currently not handling them. (This is more or less the same case already
> for the submit_multi PDU that is supported in SMPP v3.4)
>
> - We add the missing optional TLVs that are now added to various known
> PDUs. From those we currently use only 'billing_idenfitication' in the
> submit_sm and data_sm PDU. The field carries according to the SMPP v5.0
> spec an arbitrary billing information, so we're mapping this into/from
> our msg->sms.binfo field.
>
> - The patch is not intrusive, meaning it doesn't change any current
> behavior.
>
> - To allow a v5.0 connection to a SMSC, the 'interface-version = 50' can
> be configured in the 'group = smsc' scope.
>
> Please review, any comments are welcome.

committed to the svn trunk:

2012-10-14  Stipe Tolj  <stolj at kannel.org>
     * doc/userguide/userguide.xml: document that we can use SMPP v5.0
       bind connections too now.
     * gw/smsc/smpp_pdu_opt.def: add the TLVs added in SMPP v5.0.
     * gw/smsc/smpp_pdu.def: add optional TLVs to the the SMPP v3.[3|4] PDUs
       and some new PDUs as defined in SMPP v5.0.
     * gw/smpp_pdu.h: added a couple of NPI values defined in SMPP v5.0.
     * gw/smsc_smpp.c: add basic support for SMPP v5.0 handling.
     This patchset incorporates the new parts from the SMPP v5.0 spec into
     the codebase, without being intrusive to the current default behaviour.

Stipe

-- 
-------------------------------------------------------------------
Kölner Landstrasse 419
40589 DÃŒsseldorf, NRW, Germany

tolj.org system architecture      Kannel Software Foundation (KSF)
http://www.tolj.org/              http://www.kannel.org/

mailto:st_{at}_tolj.org           mailto:stolj_{at}_kannel.org
-------------------------------------------------------------------