Re: [PATCH] [white|black]list for receiver addresses
Alexander Malysh <[email protected]>
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, +1 for the feature but not for the patch itself. I would propose to make it clear in the code and userguide which list ist for which field. Please rename black-list… to black-list-sender etc. For the migration phase you can accept in the config both, black-list-sender and black-list and warn about deprecated config values. We have to keep code clean… Alex > Am 30.10.2014 um 16:51 schrieb Stipe Tolj <[email protected]>: > > Hi list, > > this is a very intuitive addition to the way we allow handling '[white|black]-list[-regex]' config directives in the 'group = core' context. > > Unfortunately the existing logic only patterns against the msg->sms.sender (source address) of the message, but not against the receiver side. > > While you may argue that this SHOULD be done by the upper application layer instead, some may find it useful to be added as feature add into the baseline svn trunk. > > Please review and vote for committing. > > Stipe > > -- > ------------------------------------------------------------------- > Kölner Landstrasse 419 > 40589 Düsseldorf, NRW, Germany > > Kannel Foundation tolj.org system architecture > http://www.kannel.org/ http://www.tolj.org/ > > mailto:stolj_{at}_kannel.org mailto:st_{at}_tolj.org > ------------------------------------------------------------------- > <gateway-white-black-list.diff>