Re: [PATCH] 'group = smsc' directive 'instances = x' to multiply the runtime instances

Am 31.10.2014 11:26, schrieb Alexander Malysh:
> Hi Stipe,
>
> don’t know why we need this? If you need some amount of equal smsc connections then:
>
> 1) create file with smsc config: e.g. smsc.conf
> 2) in the global config:
> 	include smsc.conf
> 	include smsc.conf
> 	include smsc.conf
> 	include smsc.conf
> 	include smsc.conf
> 	...
>
> I know this is a workaround, but we have just toooo much config variable and I just trying to avoid to produce more of them.

Hi Alex,

hmm, I agree, this would be a way to do it. Unfortunately I have seen 
most people rather do copy-and-paste in the same smsc_foobar.conf file 
for the groups when they to multi-binds.

On the other side, you add more SMSC specific config groups, like 'group 
= smpp-tlv' to the file, then re-including the file would case PANICs 
due that those groups are defined already, forcing you to extract those 
parts into an own file. So you start to scatter with too much separate 
files IMO.

I agree with the basic fundamental approach NOT to introduce silly 
config directives, just for a special case thing, but this has a 
real-world usage scenario, and therefore I'm +1 in adding it.

I'll consider your above notice as a -0 vote ;)

Stipe

-- 
-------------------------------------------------------------------
Kölner Landstrasse 419
40589 Düsseldorf, NRW, Germany

Kannel Foundation                 tolj.org system architecture
http://www.kannel.org/            http://www.tolj.org/

mailto:stolj_{at}_kannel.org      mailto:st_{at}_tolj.org
-------------------------------------------------------------------