Re: [PATCH] fixing possible PANIC condition

Stipe Tolj <[email protected]> Tue, 25 Sep 2018 09:46:06 +0200

Newsgroups	gmane.comp.mobile.kannel.devel
Organization	Kannel Software Foundation (KSF)
Message-ID	<[email protected]>

Am 19.09.2018 15:31, schrieb [email protected]:
> Hi Stipe,
>
> is it not easier just check for conn != NULL at the place it passed to conn_unregister ?
> assertion is very interesting at this place IMHO because it can show that someone try to unregister connection which is null but should not be null.
> This prevents from resources leak.

Hi Alex,

hope you're doing fine.

I agree, committed a fix for the possible PANIC condition by 
pre-checking before calling conn_unregister() in the handle_transaction().

Stipe

-- 
Best Regards,
Stipe Tolj

-------------------------------------------------------------------
Düsseldorf, NRW, Germany

Kannel Foundation                 tolj.org system architecture
http://www.kannel.org/            http://www.tolj.org/

stolj at kannel.org               st at tolj.org
-------------------------------------------------------------------