Re: [PATCH] fixing possible PANIC condition

--000000000000ca56870576c080f8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks a lot.

Alex


Stipe Tolj <[email protected]> schrieb am Di., 25. Sep. 2018, 09:46:

> Am 19.09.2018 15:31, schrieb [email protected]:
> > Hi Stipe,
> >
> > is it not easier just check for conn !=3D NULL at the place it passed t=
o
> conn_unregister ?
> > assertion is very interesting at this place IMHO because it can show
> that someone try to unregister connection which is null but should not be
> null.
> > This prevents from resources leak.
>
> Hi Alex,
>
> hope you're doing fine.
>
> I agree, committed a fix for the possible PANIC condition by
> pre-checking before calling conn_unregister() in the handle_transaction()=
.
>
> Stipe
>
> --
> Best Regards,
> Stipe Tolj
>
> -------------------------------------------------------------------
> D=C3=BCsseldorf, NRW, Germany
>
> Kannel Foundation                 tolj.org system architecture
> http://www.kannel.org/            http://www.tolj.org/
>
> stolj at kannel.org               st at tolj.org
> -------------------------------------------------------------------
>

--000000000000ca56870576c080f8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks a lot.</div><span>
</span><div><br></div>Alex<div><br></div><div><br><div class=3D"gmail_quote=
"><div dir=3D"ltr">Stipe Tolj &lt;<a href=3D"mailto:[email protected]">stolj=
@kannel.org</a>&gt; schrieb am Di., 25. Sep. 2018, 09:46:<br></div><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc s=
olid;padding-left:1ex">Am 19.09.2018 15:31, schrieb <a href=3D"mailto:amaly=
[email protected]" target=3D"_blank">[email protected]</a>:<br>
&gt; Hi Stipe,<br>
&gt;<br>
&gt; is it not easier just check for conn !=3D NULL at the place it passed =
to conn_unregister ?<br>
&gt; assertion is very interesting at this place IMHO because it can show t=
hat someone try to unregister connection which is null but should not be nu=
ll.<br>
&gt; This prevents from resources leak.<br>
<br>
Hi Alex,<br>
<br>
hope you&#39;re doing fine.<br>
<br>
I agree, committed a fix for the possible PANIC condition by <br>
pre-checking before calling conn_unregister() in the handle_transaction().<=
br>
<br>
Stipe<br>
<br>
-- <br>
Best Regards,<br>
Stipe Tolj<br>
<br>
-------------------------------------------------------------------<br>
D=C3=BCsseldorf, NRW, Germany<br>
<br>
Kannel Foundation=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0<a href=3D"http://tolj.org" rel=3D"noreferrer" target=3D"_blank">tolj=
.org</a> system architecture<br>
<a href=3D"http://www.kannel.org/" rel=3D"noreferrer" target=3D"_blank">htt=
p://www.kannel.org/</a>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <a href=3D=
"http://www.tolj.org/" rel=3D"noreferrer" target=3D"_blank">http://www.tolj=
.org/</a><br>
<br>
stolj at <a href=3D"http://kannel.org" rel=3D"noreferrer" target=3D"_blank"=
>kannel.org</a>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0st at=
 <a href=3D"http://tolj.org" rel=3D"noreferrer" target=3D"_blank">tolj.org<=
/a><br>
-------------------------------------------------------------------<br>
</blockquote></div></div>

--000000000000ca56870576c080f8--