Re: change my_bool to bool based on mysql 8.0.1
[email protected] Wed, 12 Dec 2018 16:01:40 +0100
| Newsgroups | gmane.comp.mobile.kannel.devel |
|---|---|
| Message-ID | <[email protected]> |
--Apple-Mail=_E4FEED93-A4B4-48EC-81CA-85E27978BB89 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi, thanks for this patch but will this patch break compilation for older = mysql versions? If yes, then something like: #ifndef mybool #define mybool bool #endif would be more suitable. Thanks, Alex > Am 11.12.2018 um 21:34 schrieb Nadir Hamid <[email protected]>: >=20 > hello Kannel Project, >=20 > in mysql 8.0.1 and above versions "my_bool" was changed to "bool". = see: > = https://docs.oracle.com/cd/E17952_01/mysql-8.0-relnotes-en/news-8-0-1.html= = <https://docs.oracle.com/cd/E17952_01/mysql-8.0-relnotes-en/news-8-0-1.htm= l> > the attached patch includes an update that renames the "my_bool" to = "bool" based on mysql 8.0.1 and up releases. >=20 > thanks >=20 > <kannel-mysql801.patch> --Apple-Mail=_E4FEED93-A4B4-48EC-81CA-85E27978BB89 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dus-ascii"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" = class=3D"">Hi,<div class=3D""><br class=3D""></div><div class=3D"">thanks = for this patch but will this patch break compilation for older mysql = versions?</div><div class=3D""><br class=3D""></div><div class=3D"">If = yes, then something like:</div><div class=3D""><br class=3D""></div><div = class=3D"">#ifndef mybool</div><div class=3D"">#define mybool = bool</div><div class=3D"">#endif</div><div class=3D""><br = class=3D""></div><div class=3D"">would be more suitable.</div><div = class=3D""><br class=3D""></div><div class=3D"">Thanks,</div><div = class=3D"">Alex<br class=3D""><div><br class=3D""><blockquote = type=3D"cite" class=3D""><div class=3D"">Am 11.12.2018 um 21:34 schrieb = Nadir Hamid <<a href=3D"mailto:[email protected]" = class=3D"">[email protected]</a>>:</div><br = class=3D"Apple-interchange-newline"><div class=3D""><div dir=3D"ltr" = style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: = 12px; font-style: normal; font-variant-caps: normal; font-weight: = normal; letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D""><div = id=3D"gmail-:1da" class=3D"gmail-gt gmail-ii" style=3D"font-size: = 12.8px; direction: ltr; margin: 8px 0px 0px; padding: 0px; font-family: = Roboto, RobotoDraft, Helvetica, Arial, sans-serif;"><div id=3D"gmail-:1d9"= class=3D"gmail-a3s gmail-aXjCH" style=3D"overflow: hidden; = font-variant-numeric: normal; font-variant-east-asian: normal; = font-stretch: normal; font-size: small; line-height: 1.5; font-family: = Arial, Helvetica, sans-serif;"><div dir=3D"ltr" class=3D"">hello Kannel = Project,<div class=3D""><br class=3D""></div><div class=3D""><p = style=3D"box-sizing: border-box; margin-bottom: 16px; margin-top: 0px; = color: rgb(36, 41, 46); font-family: -apple-system, BlinkMacSystemFont, = "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color = Emoji", "Segoe UI Emoji", "Segoe UI Symbol"; = font-size: 14px;" class=3D"">in mysql 8.0.1 and above versions "my_bool" = was changed to "bool". see:<br style=3D"box-sizing: border-box;" = class=3D""><a rel=3D"nofollow" = href=3D"https://docs.oracle.com/cd/E17952_01/mysql-8.0-relnotes-en/news-8-= 0-1.html" target=3D"_blank" style=3D"color: rgb(3, 102, 214); = box-sizing: border-box;" = class=3D"">https://docs.oracle.com/cd/E17952_01/mysql-8.0-relnotes-en/news= -8-0-1.html</a></p><p style=3D"box-sizing: border-box; margin-bottom: = 16px; margin-top: 0px; color: rgb(36, 41, 46); font-family: = -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, = Arial, sans-serif, "Apple Color Emoji", "Segoe UI = Emoji", "Segoe UI Symbol"; font-size: 14px;" class=3D"">the= attached patch includes an update that renames the "my_bool" to "bool" = based on mysql 8.0.1 and up releases.</p><div style=3D"box-sizing: = border-box; margin-top: 0px; color: rgb(36, 41, 46); font-family: = -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, = Arial, sans-serif, "Apple Color Emoji", "Segoe UI = Emoji", "Segoe UI Symbol"; font-size: 14px; = margin-bottom: 0px;" class=3D"">thanks</div></div></div><div = class=3D"gmail-yj6qo"></div><div = class=3D"gmail-adL"></div></div></div><div class=3D"gmail-gt gmail-hq = gmail-a10" id=3D"gmail-:1do" style=3D"margin: 15px 0px; clear: both; = font-size: 12.8px; font-family: Roboto, RobotoDraft, Helvetica, Arial, = sans-serif;"><br = class=3D"gmail-Apple-interchange-newline"></div></div><span = id=3D"cid:f_jpk7f0i70"><kannel-mysql801.patch></span><style = class=3D"">ul[class*=3D'mb-extra__public-links'], = ul[class*=3D'mb-note__public-links'], ul[class*=3D'mb-task__public-links']= { display: none !important; }</style></div></blockquote></div><br = class=3D""></div></body></html>= --Apple-Mail=_E4FEED93-A4B4-48EC-81CA-85E27978BB89--