Re: Error: undefined entity in lightning-toolbar.xul [SeaMonkey Integration]

Hi, Phil...

On 09/28/12 11:50 am, Philip Chee thus wrote :
> Bug 785692 caused several regressions in SeaMonkey one of which (Bug
> 795342) isn't fixed.
> 
> References:
> Bug 785692 - Implement the AppButton on toolbars of all tabs.
> [Fixed]  Bug 792884 - Event dialog broken due to FileLink feature
> [Error: ReferenceError: cloudFileAccounts is not defined].
> [Fixed]  Bug 792849 - lightning nightly broken on Seamonkey nightly
> since 20120919.
> [New]  Bug 795342 - Toolbars in Task/Calendar tabs missing due to
> undefined entities in SeaMonkey.
> 
> Fri Sep 28 2012 23:26:25
> Error: undefined entity
> Source file: chrome://lightning/content/lightning-toolbar.xul
> Line: 108, Column: 7
> Source code:
>       <toolbarbutton id="calendar-appmenu-button"
> 
> So possible solutions:
> 
> 1. Using the removeelement trick in suite-overlay-sidebar.xul doesn't
> work. Or rather it works but comes too late to prevent the undefined
> entities error.
> 
> 2. Add these entities to the SeaMonkey messenger.dtd.
> 
> 3. Move these entities to the Lightning locale file
> (lightning-toolbar.dtd).
> 
> 4. Something else.
> 
> Your thoughts Gentlebeings?
> 

My vote would be for option #3, as not every SM user wants/installs
Lightning, and there's no need for the extra bloat in the base product.

Beyond that, however, I'm afraid that I couldn't weigh in on the
technical advantages of one over the other.

Cheers

-- 
Lewis
-------------------------------------------------------------
Lewis G Rosenthal, CNA, CLP, CLE, CWTS
Rosenthal & Rosenthal, LLC                www.2rosenthals.com
Need a managed Wi-Fi hotspot?                www.hautspot.com
visit my IT blog                www.2rosenthals.net/wordpress
-------------------------------------------------------------