Re: CR-Client: client/xfadeplayer

oops, good catch.  I'll add that and unless there are any objections 
begin the commit.



Eric Hyche wrote:
> Nick,
> 
> Here are my comments:
> 
> - guids.cpp needs a license header
> 
> Other than that, this looks good to me.
> 
> Eric
> 
> =======================================
> Eric Hyche ([email protected])
> Principal Engineer
> RealNetworks, Inc.
> 
> 
>> -----Original Message-----
>> From: [email protected] [mailto:[email protected]]
>> On Behalf Of Nicholas Hart
>> Sent: Wednesday, February 25, 2009 1:47 PM
>> To: [email protected]
>> Subject: [Helix-client-dev] CR-Client: client/xfadeplayer
>>
>> I haven't done one of these submissions in a while, so if I messed anything up please let me know.  :)
>>
>> Modified by: [email protected]
>> Date: 02/24/09
>> Project: N/A
>> Bug Number: N/A
>> Bug URL: N/A
>>
>> Synopsis: initial commit for a helix component plugin that implements a player object which provides
>> cross-fade and gap-less playback between audio tracks.
>>
>> Overview: please see SOD document for details about this project:
>> https://helixcommunity.org/viewcvs/helix-client/www/2009/devdocs/XFP-SOD-
>> CrossFadePlayer.doc?limit_changes=100&revision=1.2&view=log
>> This is the initial checkin for this product.  It is not yet finished, but I want to get what I have
>> written so far checked in to CVS for safety.
>>
>> Files Added:
>> umakefil - makefile script
>> xfadeplayerlib - makefile script for static lib xfadeplayerdll - makefile script for dll
>> xfadeplayerdll_win32.pcf - win32 specific makefile script additions hxcrossfadeplayer.h - header for
>> HXCrossFadePlayer class hxcrossfadeplayer.cpp - source for HXCrossFadePlayer class hxcrossfadeplugin.h
>> - header for HXCrossFadePlugin class hxcrossfadeplugin.cpp - source for HXCrossFadePlugin class
>> guids.cpp - source for guid symbols pub/ihxcrossfadeplayer.h - interface and guids for
>> IHXCrossFadePlayer test/umakefil - makefile script for test application test/win32.pcf - win32
>> specific makefile script additions test/mac.pcf - mac specific makefile script additions test/unix.pcf
>> - unix specific makefile script additions test/main.cpp - source for test program main
>> test/testengine.h - header for client engine loader class test/testengine.cpp - source for client
>> engine loader class test/testplayer.h - header for test player class test/testplayer.cpp - source for
>> test player class
>>
>>
>> Files Modified:
>> hxclient_3_1_0_atlas.bif - added client_xfadeplayer and client_xfadeplayer_test targets
>>
>> Image Size and Heap Use impact (Client -Only):
>> xfadeplayer.dll - 36,864 bytes
>> heap use not measured, but shouldn't be much larger than using two instances of IHXPlayer.
>>
>> Platforms and Profiles Affected:
>> win32
>> mac - should build, not verified or tested linux/unix - should build, not verified or tested
>>
>> Distribution Libraries Affected:
>> N/A
>>
>> Distribution library impact and planned action:
>> N/A
>>
>> Platforms and Profiles Build Verified:
>> win32
>>
>> Platforms and Profiles Functionality verified:
>> win32
>>
>> Branch: HEAD and hxclient_3_1_0_atlas
>>
>> Copyright assignment: I am a RealNetworks employee or contractor
>>
>> QA Instructions:
>> build and run the client_xfadeplayer_test application.
>>
>>
>> Index: hxclient_3_1_0_atlas.bif
>> ===================================================================
>> RCS file: /cvsroot/client/build/BIF/hxclient_3_1_0_atlas.bif,v
>> retrieving revision 1.86
>> diff -u -w -r1.86 hxclient_3_1_0_atlas.bif
>> --- hxclient_3_1_0_atlas.bif	13 Feb 2009 17:04:36 -0000	1.86
>> +++ hxclient_3_1_0_atlas.bif	25 Feb 2009 18:10:22 -0000
>> @@ -17984,5 +17984,35 @@
>>        </dependlist>
>>      </module>
>>
>> +    <!-- CLIENT/XFADEPLAYER -->
>> +    <module id="client_xfadeplayer" group="client"
>> name="client/xfadeplayer">
>> +      <source_dependlist>
>> +        common_include
>> +      </source_dependlist>
>> +      <dependlist>
>> +        common_container
>> +        common_runtime
>> +        common_util
>> +        common_system
>> +        common_dbgtool
>> +      </dependlist>
>> +    </module>
>> +
>> +    <!-- CLIENT/XFADEPLAYER/TEST -->
>> +    <module id="client_xfadeplayer_test" group="client"
>> name="client/xfadeplayer/test">
>> +      <source_dependlist>
>> +        common_include
>> +      </source_dependlist>
>> +      <dependlist>
>> +        common_container
>> +        common_runtime
>> +        common_util
>> +        common_system
>> +        common_dbgtool
>> +        client_xfadeplayer
>> +      </dependlist>
>> +    </module>
>> +
>> +
>>    </targets>
>>  </build>
>>
> 
> 
> 
>