[Helix-client-dev] Re: [datatype-dev] Fixed audiohash generation bug [GMPMetaEditor]

Checked in.

On Wed, Feb 10, 2010 at 7:06 PM, Qiang Luo <[email protected]> wrote:
> Looks good to me.
> Qiang
>
> On 2/10/2010 1:50 AM, Petar Basic wrote:
>>
>> Modified by: pbasic at real.com
>> Date: 2010/02/10
>> Project: GMP MetaEditor (meta3gp.exe)
>>
>> Synopsis:
>> Fixed audiohash generation bug [GMPMetaEditor]
>>
>> Details:
>> In extraction mode, metaeditor.dll was suppressing packet processing
>> without being aware of audiohash generation mode.  The logic which
>> decides whether to suppress packet processing has now been moved to
>> meta3gp.exe which has access to necessary information.
>>
>> Testing:
>> Verified that different hash gets generated for media files with
>> different audio content.  Verified that same hash gets generated for
>> media files with same audio content but with different metadata.
>>
>> Files Modified:
>> datatype/tools/dtdriver/apps/meta3gp/main.cpp
>> datatype/tools/metaeditor/editor.cpp
>>
>> Platforms and Profiles Affected:
>> All
>>
>> Image Size and Heap Use impact:
>> None
>>
>> Platforms and Profiles Build Verified:
>> system id: win32-i386-vc7, sunos-5.10-sparc-studio11
>> profile: helix-client-all-defines
>>
>> Platforms and Profiles Functionality Verified:
>> x86 Windows XP SP2
>> Sparc SunOS 5.10
>>
>> Branch:
>> GMPMetaEditor
>>
>> Copyright assignment:
>> I am a RealNetworks employee or contractor.
>>
>
>