Re: Add vorbis_dsp_init() ?

Erik de Castro Lopo <[email protected]>
Newsgroups gmane.comp.multimedia.ogg.vorbis.devel
Organization Erik Conspiracy Secret Labs
Message-ID <[email protected]>
Conrad Parker wrote:

> This mozilla bug report is a crash triggered by a Vorbis file with
> corrupt headers:
> https://bugzilla.mozilla.org/show_bug.cgi?id=481601

???

So how come lib/block.c in vorbis svn gets renamed to
lib/vorbis_block.c?

> The patch to fix the crash adds a new vorbis_dsp_init() function to
> libvorbis, and calls

Since the vorbis_dsp_state stuct is defined in a public header
file, why do you need to add a function to libvorbis? The memset
could just  as easily  and correctly be done in fishsound.

Erik
-- 
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
"Always code as if the person who ends up maintaining your
code will be a violent psychopath who knows where you live."
-- Martin Golding
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.