Re: Add vorbis_dsp_init() ?

2009/3/15 Erik de Castro Lopo <[email protected]>:
> Conrad Parker wrote:
>
>> This mozilla bug report is a crash triggered by a Vorbis file with
>> corrupt headers:
>> https://bugzilla.mozilla.org/show_bug.cgi?id=481601
>
> ???
>
> So how come lib/block.c in vorbis svn gets renamed to
> lib/vorbis_block.c?

that's just part of the import into the mozilla source tree,
apparently to avoid filename conflicts.

>> The patch to fix the crash adds a new vorbis_dsp_init() function to
>> libvorbis, and calls
>
> Since the vorbis_dsp_state stuct is defined in a public header
> file, why do you need to add a function to libvorbis? The memset
> could just  as easily  and correctly be done in fishsound.

yes, that's what will happen if it's decided not to apply the libvorbis patch.

Conrad.