Re: Use of alloca in vorbis_comment_add_tag
Ralph Giles <[email protected]> Tue, 13 Oct 2015 16:19:46 -0700
| Newsgroups | gmane.comp.multimedia.ogg.vorbis.devel |
|---|---|
| Message-ID | <[email protected]> |
On 2015-10-12 12:04 PM, Robert Kausch wrote: > Please consider using _ogg_malloc/_ogg_free in place of alloca in > vorbis_comment_add_tag. alloca will cause undefined behaviour/crashing > when it causes a stack overflow which can easily happen when adding > cover art in a METADATA_BLOCK_PICTURE comment. Thanks for the report. I've done a quick fix. Please test. https://git.xiph.org/?p=vorbis.git;a=commitdiff;h=c75b3b1282de1010883aa1391bc8ea31dc8ac98e -r