Re: Use of alloca in vorbis_comment_add_tag
Robert Kausch <[email protected]> Thu, 15 Oct 2015 14:57:57 +0200 (CEST)
| Newsgroups | gmane.comp.multimedia.ogg.vorbis.devel |
|---|---|
| Message-ID | <1647378800.3100240.1444913877869.JavaMail.open-xchange@omgreatgod.store> |
--===============1942483913== Content-Type: multipart/alternative; boundary="----=_Part_3100239_891380805.1444913877714" ------=_Part_3100239_891380805.1444913877714 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit > Ralph Giles <[email protected]> hat am 14. Oktober 2015 um 01:19 geschrieben: > > Thanks for the report. I've done a quick fix. Please test. > > https://git.xiph.org/?p=vorbis.git;a=commitdiff;h=c75b3b1282de1010883aa1391bc8ea31dc8ac98e Works great, thanks! I think replacing alloca in vorbis_comment_query and vorbis_comment_query_count is not really necessary as only the tag id without content is used in those methods. On the other hand, it might be a good idea to avoid alloca where possible. An alternative would be to continue using alloca in those two methods, but check and fail if the id lenght is greater than a few kB. Robert ------=_Part_3100239_891380805.1444913877714 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"><head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/> </head><body style=""><div> <div>> Ralph Giles <[email protected]> hat am 14. Oktober 2015 um 01:19 geschrieben:<br>> <br>> Thanks for the report. I've done a quick fix. Please test.<br>> <br>> https://git.xiph.org/?p=vorbis.git;a=commitdiff;h=c75b3b1282de1010883aa1391bc8ea31dc8ac98e<br><br></div> <div>Works great, thanks!</div> <div> </div> <div>I think replacing alloca in vorbis_comment_query and vorbis_comment_query_count is not really necessary as only the tag id without content is used in those methods. On the other hand, it might be a good idea to avoid alloca where possible. An alternative would be to continue using alloca in those two methods, but check and fail if the id lenght is greater than a few kB.</div> </div> <div> </div> <div>Robert</div></body></html> ------=_Part_3100239_891380805.1444913877714-- --===============1942483913== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Vorbis-dev mailing list [email protected] http://lists.xiph.org/mailman/listinfo/vorbis-dev --===============1942483913==--