Patchfiles
Jeff Snider <[email protected]>
| Newsgroups | gmane.comp.otrs.devel |
|---|---|
| Message-ID | <[email protected]> |
I just recently upgraded from 2.4 to 3.0 (yes, yes, way behind) at our university and I made a few very small changes while doing so. Some of them may be of interest to others so I've outlined the whys below and attached patch files. reply-dropdown-click.patch I changed the event that is used on the reply dropdown from change to click to play nicer with popup blockers. I found that it didn't make any difference in IE7 and 8 but in all of the others I tested (FF3.6, FF8, Safari, Chrome, IE9) it didn't trip the popup blocker anymore. widget-overflow-hidden.patch Our CustomerUser widget showed a horizontal scrollbar for about three pixels and it didn't seem to impact our set up anywhere else, so I turned it off. I realize this may have been a conscious decision to accommodate some configurations but it worked better for us this way. ldap-split-on-whitespace.patch We are using Kernel::System::CustomerUser::LDAP for our CustomerUser module and I found it was not splitting up the search string as I would expect. I added whitespace to the split since that seemed to me to be the intent given what it was already splitting on. Thanks! Everybody here is glowing about the "new" (to them) version. We appreciate all the hard work! -Jeff _______________________________________________ OTRS mailing list: dev - Webpage: http://otrs.org/ Archive: http://lists.otrs.org/pipermail/dev To unsubscribe: http://lists.otrs.org/cgi-bin/listinfo/dev
widget-overflow-hidden.patch
(application/octet-stream, 505 B)
diff -r e6aa70dbfe82 -r 1ce46827cd44 var/httpd/htdocs/skins/Agent/default/css/Core.Widget.css
--- a/var/httpd/htdocs/skins/Agent/default/css/Core.Widget.css Fri Jan 06 13:52:35 2012 -0600
+++ b/var/httpd/htdocs/skins/Agent/default/css/Core.Widget.css Thu Jan 12 13:47:08 2012 -0600
@@ -119,7 +119,7 @@
-moz-border-radius-bottomleft: 2px;
border-bottom-right-radius: 2px;
border-bottom-left-radius: 2px;
- overflow: auto;
+ overflow: hidden;
}
.WidgetSimple.Collapsed > .Content {
reply-dropdown-click.patch
(application/octet-stream, 2 KB)
diff -r e6aa70dbfe82 -r 1ce46827cd44 Kernel/Output/HTML/Standard/AgentTicketOverviewPreview.dtl
--- a/Kernel/Output/HTML/Standard/AgentTicketOverviewPreview.dtl Fri Jan 06 13:52:35 2012 -0600
+++ b/Kernel/Output/HTML/Standard/AgentTicketOverviewPreview.dtl Thu Jan 12 13:47:08 2012 -0600
@@ -209,7 +209,7 @@
</form>
<!--dtl:js_on_document_complete-->
<script type="text/javascript">//<![CDATA[
- $('#$QData{"FormID"} select[name=ResponseID]').bind('change', function (Event) {
+ $('#$QData{"FormID"} select[name=ResponseID]').bind('click', function (Event) {
var URL;
if ($(this).val() > 0) {
@@ -218,9 +218,7 @@
// reset the select box so that it can be used again from the same window
$(this).val('0');
}
- });
- // make sure this click event does not bubble up to the table row and execute its click handler
- $('#$QData{"FormID"} select[name=ResponseID]').bind('click', function (Event) {
+
Event.stopPropagation();
return false;
});
diff -r e6aa70dbfe82 -r 1ce46827cd44 Kernel/Output/HTML/Standard/AgentTicketZoom.dtl
--- a/Kernel/Output/HTML/Standard/AgentTicketZoom.dtl Fri Jan 06 13:52:35 2012 -0600
+++ b/Kernel/Output/HTML/Standard/AgentTicketZoom.dtl Thu Jan 12 13:47:08 2012 -0600
@@ -501,7 +501,7 @@
</form>
<!-- dtl:block:ArticleReplyAsDropdownJSOnLoad -->
<script type="text/javascript">//<![CDATA[
-$('#$QData{"FormID"} select[name=ResponseID]').bind('change', function (Event) {
+$('#$QData{"FormID"} select[name=ResponseID]').bind('click', function (Event) {
var URL;
if ($(this).val() > 0) {
@@ -516,7 +516,7 @@
<!-- dtl:block:ArticleReplyAsDropdownJSStatic -->
<!-- dtl:js_on_document_complete -->
<script type="text/javascript">//<![CDATA[
-$('#$QData{"FormID"} select[name=ResponseID]').bind('change', function (Event) {
+$('#$QData{"FormID"} select[name=ResponseID]').bind('click', function (Event) {
var URL;
if ($(this).val() > 0) {
ldap-split-on-whitespace.patch
(application/octet-stream, 570 B)
diff -r e6aa70dbfe82 -r 1ce46827cd44 Kernel/System/CustomerUser/LDAP.pm
--- a/Kernel/System/CustomerUser/LDAP.pm Fri Jan 06 13:52:35 2012 -0600
+++ b/Kernel/System/CustomerUser/LDAP.pm Thu Jan 12 13:47:08 2012 -0600
@@ -290,7 +290,7 @@
my $Filter = '';
if ( $Param{Search} ) {
my $Count = 0;
- my @Parts = split( /\+/, $Param{Search}, 6 );
+ my @Parts = split( /\+|\s+/, $Param{Search}, 6 );
for my $Part (@Parts) {
$Part = $Self->{SearchPrefix} . $Part . $Self->{SearchSuffix};
$Part =~ s/(\%+)/\%/g;
smime.p7s
(application/pkcs7-signature, 4.7 KB) - not displayed