Re: [PATCH for Dlang support] Push parser
Akim Demaille <[email protected]> Mon, 12 Apr 2021 06:46:16 +0200
| Newsgroups | gmane.comp.parsers.bison.patches |
|---|---|
| Message-ID | <[email protected]> |
Hi Adela, > Le 2 avr. 2021 à 01:23, Adela Vais <[email protected]> a écrit : > > În sâm., 27 mar. 2021 la 08:35, Akim Demaille <[email protected]> a scris: > >> I see that you have keep the possibility for the regular pull parser >> to use local variables. Have you benchmarked if this is worth the >> effort? Because it there's no measurable difference, you may just >> as well always use attributes of the parser object. That would simplify >> the skeleton. >> > > I benchmarked it, and there is no measurable difference. I put the > variables as class attributes. Good! >> I don't think we need too many examples. So I would go with keeping >> a super simple one, and have the other one grow with all the bells >> and whistles, a bit like what the bistromathic example does in C. >> > > I added the push parser to the 'calc' example. Perfect! I would suggest that this example also use the token constructor functions. Installed. Cheers!