Re: Re: [PEAR-DEV] LiveUser - session_set_cookie_params()
Lukas Smith <[email protected]>
| Newsgroups | gmane.comp.php.pear.liveuser |
|---|---|
| Organization | BackendMedia GbR |
| Message-ID | <[email protected]> |
Arnaud Limbourg wrote: > I changed it to hardcoded number of seconds, 86400 for a day as it will > not likely change. Well I dont understand how hardcoding the value should fix the issue? > I'm cc'ing LU list as they may have a reason for the constant for which > I am unaware. For the record, I don't see the added value in using a > constant (as we know constants are slow) when the number of seconds in a > day will not change in the near future. Doing the math 60*60*24 at every > file load seems like a waste. I put it into a constant because we had an issue where the number was accidentaly screwed up and I wanted to prevent such mistakes in the future. However I dont mind recomputing the value in the constant definition. Actually I dont care eitherway. I just dont understand why there would be a bug here that is fixed by replacing the constant. Eitherway the constant is still used in two other places. regards, Lukas -- Lukas Smith [email protected] _______________________________ BackendMedia www.backendmedia.com [email protected] Linn Zwoch Smith GbR Pariser Str. 44 D-10707 Berlin Tel +49 30 83 22 50 00 Fax +49 30 83 22 50 07