Re: Re: [PEAR-DEV] LiveUser - session_set_cookie_params()

Arnaud Limbourg <arnaud-GdXxm9JVFPlWk0Htik3J/[email protected]>
Newsgroups gmane.comp.php.pear.liveuser
Message-ID <[email protected]>
>> I changed it to hardcoded number of seconds, 86400 for a day as it 
>> will not likely change.
>
> Well I dont understand how hardcoding the value should fix the issue?

It's just that I don't understand why recomputing the value does 
anything other
than waste CPU. I mean we know that the result will always be 86400.

> I put it into a constant because we had an issue where the number was
> accidentaly screwed up and I wanted to prevent such mistakes in the
> future. However I dont mind recomputing the value in the constant
> definition. Actually I dont care eitherway.

How can it become screwed up ? (note: i'm just trying to understand :)

> I just dont understand why there would be a bug here that is fixed by
> replacing the constant.

it's more to save resources than to fix a bug imho.

> Eitherway the constant is still used in two other places.

I didn't see them in my grep output, I will pay closer attention.

> regards,
> Lukas

Arnaud.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.