Re: Re: [PEAR-DEV] LiveUser - session_set_cookie_params()
Lukas Smith <[email protected]>
| Newsgroups | gmane.comp.php.pear.liveuser |
|---|---|
| Organization | BackendMedia GbR |
| Message-ID | <[email protected]> |
Arnaud Limbourg wrote: >>> I changed it to hardcoded number of seconds, 86400 for a day as it >>> will not likely change. >> >> >> Well I dont understand how hardcoding the value should fix the issue? well that is what the original bug report suggested .. right? > > It's just that I don't understand why recomputing the value does > anything other > than waste CPU. I mean we know that the result will always be 86400. > >> I put it into a constant because we had an issue where the number was >> accidentaly screwed up and I wanted to prevent such mistakes in the >> future. However I dont mind recomputing the value in the constant >> definition. Actually I dont care eitherway. > > > How can it become screwed up ? (note: i'm just trying to understand :) - time() + (8 * 6400 * $this->_options['session_cookie_params']['lifetime'])), + time() + (LIVEUSER_DAY_SECONDS * $this->_options['session_cookie_params']['lifetime'])), regards, Lukas Smith [email protected] _______________________________ BackendMedia www.backendmedia.com [email protected] Linn Zwoch Smith GbR Pariser Str. 44 D-10707 Berlin Tel +49 30 83 22 50 00 Fax +49 30 83 22 50 07