[HIGH] STR #4276: Incomplete fix of STR #4232 causes crash in RHEL7
Richard Hughes <[email protected]> Fri, 15 Feb 2013 09:03:22 -0800 (PST)
| Newsgroups | gmane.comp.printing.cups.bugs |
|---|---|
| Message-ID | <[email protected]> |
DO NOT REPLY TO THIS MESSAGE. INSTEAD, POST ANY RESPONSES TO THE LINK BELOW. [STR New] In STR #4232 i attached the file https://www.cups.org/strfiles/4232/0001-Correctly-call-DeleteDevice-when-using-colord-on-lin.patch This did the following to fix printers being removed on RHEL and Fedora: - dbus_message_iter_append_basic(&args, DBUS_TYPE_STRING, &device_id); + dbus_message_iter_append_basic(&args, DBUS_TYPE_OBJECT_PATH, &device_path); In http://svn.easysw.com/public/cups/trunk@10761 7a7537e8-13f0-0310-91df-b6672ffda945 mike committed a fix that was different: - dbus_message_iter_append_basic(&args, DBUS_TYPE_STRING, &device_id); + dbus_message_iter_append_basic(&args, DBUS_TYPE_OBJECT_PATH, &device_id); This causes a high profile crash in RHEL 7 which triggers the automatic crash reporting service. The outcome is now a segfault of cupsd, rather than the printer being removed. This will affect any Linux distribution that ships colord and cups where the user tries to remove a print queue. Thanks, Richard. Link: https://www.cups.org/str.php?L4276 Version: 1.7-current