Re: Updated: CJK TrueType mappings and aliases for Windows installer |

Russell,

Russell Lang wrote:
> Users would be unlikely to find the standalone executable.
> I prefer your suggestion on IRC, that it be an option in the 
> installer that is disabled by default.  The attached patch 
> does this.

This sounds fine in principal, but from reviewing the source I can't
tell (don't know where it is establisthed) that the checkbox is *NOT*
checked by default.

It isn't at all convenient for me to apply your patch to the GSview
sources (do you even have a CVS?). My patch tool on windows is pretty
flaky, thus I will not take the time to verify your patches applied
to some GSview source.

I do see the default setting:

+BOOL g_bCJKFonts = FALSE;
  BOOL g_bAllUsers = FALSE;

and the other reference:

+			g_bCJKFonts = (SendDlgItemMessage(g_hMain,
+				IDC_CJK_FONTS, BM_GETCHECK, 0, 0)
+				== BST_CHECKED);
  			g_bAllUsers = (SendDlgItemMessage(hwnd,
  				IDC_ALLUSERS, BM_GETCHECK, 0, 0
  				) == BST_CHECKED);

but from:

+    CONTROL         "Use Windows TrueType fonts for Chinese, Japanese 
and Korean",IDC_CJK_FONTS,"Button",
+                    BS_AUTOCHECKBOX | WS_TABSTOP,8,156,220,12

I can't tell if the checkbox is 'checked' by default. This may be
obvious to a more capable windows developer than myself. It concerns
me particularly since the "All Users" checkbox seems to be checked
by default in gs46w32.exe install (maybe this changed). [ see PNG ]

Please double check that when a user does the 'default' install,
not clicking on any boxes that aren't already checked, that the
creation of the cidfmap does not occur.

I assume that you've checked that the cidfmap is OK (except for GS
bugs that you are free to submit).

Once you confirm that the default action is *NOT* checked, please
go ahead and commit it.

BTW, this also would be nice to have in GS_8_1X if you feel like
committing it there as well.

Regards,
Ray
___________________________________________________________________

_______________________________________________
gs-code-review mailing list
[email protected]
http://www.ghostscript.com/mailman/listinfo/gs-code-review