Re: Updated: CJK TrueType mappings and aliases for Windows installer

Ray,

> Russell Lang wrote:
> > Users would be unlikely to find the standalone executable.
> > I prefer your suggestion on IRC, that it be an option in the 
> > installer that is disabled by default.  The attached patch 
> > does this.
> 
> This sounds fine in principal, but from reviewing the source I can't
> tell (don't know where it is establisthed) that the checkbox is *NOT*
> checked by default.
> 
> It isn't at all convenient for me to apply your patch to the GSview
> sources (do you even have a CVS?). My patch tool on windows is pretty
> flaky, thus I will not take the time to verify your patches applied
> to some GSview source.

The patch is applied to the GS installer, not the GSview installer.
lib/cidfmap is a ghostscript file.  The GSview installer does not and 
will not change any ghostscript files.

(Current GSview sources are not in CVS, only my partial rewrite).
A decent Windows patch tool is in
  http://unxutils.sourceforge.net/

> I do see the default setting:
> 
> +BOOL g_bCJKFonts = FALSE;
>   BOOL g_bAllUsers = FALSE;
> 
> and the other reference:
> 
> +			g_bCJKFonts = (SendDlgItemMessage(g_hMain,
> +				IDC_CJK_FONTS, BM_GETCHECK, 0, 0)
> +				== BST_CHECKED);
>   			g_bAllUsers = (SendDlgItemMessage(hwnd,
>   				IDC_ALLUSERS, BM_GETCHECK, 0, 0
>   				) == BST_CHECKED);
> 
> but from:
> 
> +    CONTROL         "Use Windows TrueType fonts for Chinese, Japanese 
> and Korean",IDC_CJK_FONTS,"Button",
> +                    BS_AUTOCHECKBOX | WS_TABSTOP,8,156,220,12
> 
> I can't tell if the checkbox is 'checked' by default. This may be
> obvious to a more capable windows developer than myself. It concerns
> me particularly since the "All Users" checkbox seems to be checked
> by default in gs46w32.exe install (maybe this changed). [ see PNG ]
> 
> Please double check that when a user does the 'default' install,
> not clicking on any boxes that aren't already checked, that the
> creation of the cidfmap does not occur.

This has been tested.  By default, the check box is unchecked and 
lib/cidfmap is not changed.  If the user checks the checkbox, 
lib/cidfmap will be updated.

In the GS installer, the "Install Fonts" checkbox is set using
  SendDlgItemMessage(g_hMain, IDC_INSTALL_FONTS, 
      BM_SETCHECK, BST_CHECKED,  0);
An AUTOCHECKBOX is AUTO because it will change state when the user 
clicks on it, without requiring additional code.

I have attached a PNG image of the installer defaults.

> I assume that you've checked that the cidfmap is OK (except for GS
> bugs that you are free to submit).

I have attached the lib/cidfmap created on my system.
While the file is syntactically correct, I am not certain that all 
aliases are appropriate, nor am I certain that the CSI Supplement
values are correct.  The values chosen are better than having
no CJK fonts at all.

> Once you confirm that the default action is *NOT* checked, please
> go ahead and commit it.
> 
> BTW, this also would be nice to have in GS_8_1X if you feel like
> committing it there as well.

Are you approving committing it to GS CVS HEAD (for 8.50) and 
GS_8_1X?

_______________________________________________
gs-code-review mailing list
[email protected]
http://www.ghostscript.com/mailman/listinfo/gs-code-review