New Ghostscript/GhostPDL compiler warnings - 2018-02-06-06:30:07 - 38e0c643e62087c089c59c9ad44fc468dd09cd37

Previous Revision: f6005484617ada241d2f5f4deee4808616474831
 Current Revision: 38e0c643e62087c089c59c9ad44fc468dd09cd37

commit 38e0c643e62087c089c59c9ad44fc468dd09cd37
Author:     Robin Watts <[email protected]>
AuthorDate: Fri Feb 2 12:48:07 2018 +0000
CommitDate: Tue Feb 6 12:34:41 2018 +0000

    Tweak bitmap interpolater patch size.
    
    When we interpolate an image, we restrict the interpolation to
    the "patch" of the destination image that is actually visible.
    Previously, the calculation of this patch has been inaccurate,
    resulting in a larger area being decoded than was actually
    needed.
    
    While this extra work was largely mitigated by the "Active" area
    detection code, it has meant that the contribution calculations
    within the scaler were 'wrapping' the outside pixels in the
    region to avoid accessing out of bounds.
    
    This upsets the new library we are working on to do the scaling,
    and it's basically inelegant. Instead we fix the destination
    patch calculations so that the patch is correctly sized based
    upon the available source data. This is safe to do because we
    know the source data was already expanded.

base/gxiscale.c
base/sisparam.h



Ghostscript:

new scan-build warnings:

./base/gxiscale.c:335:9: warning: Value stored to 'rrect_y0' is never read
        rrect_y0 = rect_y0;
        ^          ~~~~~~~

./base/gxiscale.c:347:9: warning: Value stored to 'rrect_y1' is never read
        rrect_y1 = rect_y1;
        ^          ~~~~~~~


http://miles.ghostscript.com:8080/artifex/38e0c643e62087c089c59c9ad44fc468dd09cd37/gs/index.html

http://miles.ghostscript.com:8080/artifex/38e0c643e62087c089c59c9ad44fc468dd09cd37/gs-scan-build.txt




GhostPCL:

new scan-build warnings:

./base/gxiscale.c:335:9: warning: Value stored to 'rrect_y0' is never read
        rrect_y0 = rect_y0;
        ^          ~~~~~~~

./base/gxiscale.c:347:9: warning: Value stored to 'rrect_y1' is never read
        rrect_y1 = rect_y1;
        ^          ~~~~~~~


http://miles.ghostscript.com:8080/artifex/38e0c643e62087c089c59c9ad44fc468dd09cd37/pcl/index.html

http://miles.ghostscript.com:8080/artifex/38e0c643e62087c089c59c9ad44fc468dd09cd37/pcl-scan-build.txt