New Ghostscript/GhostPDL compiler warnings - 2018-02-10-09:30:02 - 01a71ecbfe576d0a840946a0089f23ce131e995d

Previous Revision: da66356a665432f998642b2e9c45756f876f0996
 Current Revision: 01a71ecbfe576d0a840946a0089f23ce131e995d

commit 01a71ecbfe576d0a840946a0089f23ce131e995d
Author:     Ray Johnston <[email protected]>
AuthorDate: Tue Feb 6 11:53:24 2018 -0800
CommitDate: Sat Feb 10 09:09:09 2018 -0800

    Change from CMM_THREAD_SAFE #define to a gscms_is_threadsafe function
    
    In preparation for enabling sharing the profiles and link cache among
    rendering threads, switch from a compile time flag to a function that
    is returned by the CMS interface module linked in (e.g gsicc_lcms2.c)
    
    This avoids more build machinery to propagate the flag, and ensures
    that the flag won't be mis-matched to the CMS in use.
    
    Also flag a few FIXME places identified that relate to multi-threaded
    sharing of profiles and the profile link cache. Initially, even though
    lcms2art is thread safe, return "false" until the multi-threaded
    rendering works.

base/gdevp14.c
base/gsicc_cms.h
base/gsicc_lcms2.c
base/gsicc_lcms2art.c
base/gxcldev.h
base/gxclthrd.c



Ghostscript:

new gcc warnings (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609): 

./base/gsicc_cms.h:99:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
./base/gsicc_lcms2art.c:927:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]

http://miles.ghostscript.com:8080/artifex/01a71ecbfe576d0a840946a0089f23ce131e995d/gs-gcc-warnings.txt



new clang warnings (clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)): 

./base/gsicc_lcms2art.c:927:1: warning: no previous prototype for function 'gscms_is_threadsafe' [-Wmissing-prototypes]
gscms_is_threadsafe()
^
./base/gsicc_cms.h:99:6: note: this declaration is not a prototype; add 'void' to make it a prototype for a zero-parameter function
bool gscms_is_threadsafe();
     ^
                         void


http://miles.ghostscript.com:8080/artifex/01a71ecbfe576d0a840946a0089f23ce131e995d/gs-clang-warnings.txt



new scan-build warnings:

./base/gsicc_cms.h:99:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
 bool gscms_is_threadsafe();
 ^

./base/gsicc_lcms2art.c:927:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
 gscms_is_threadsafe()
 ^


http://miles.ghostscript.com:8080/artifex/01a71ecbfe576d0a840946a0089f23ce131e995d/gs/index.html

http://miles.ghostscript.com:8080/artifex/01a71ecbfe576d0a840946a0089f23ce131e995d/gs-scan-build.txt




GhostPCL:

new gcc warnings (gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609): 

./base/gsicc_cms.h:99:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
./base/gsicc_lcms2art.c:927:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]

http://miles.ghostscript.com:8080/artifex/01a71ecbfe576d0a840946a0089f23ce131e995d/pcl-gcc-warnings.txt



new scan-build warnings:

./base/gsicc_cms.h:99:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
 bool gscms_is_threadsafe();
 ^

./base/gsicc_lcms2art.c:927:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
 gscms_is_threadsafe()
 ^


http://miles.ghostscript.com:8080/artifex/01a71ecbfe576d0a840946a0089f23ce131e995d/pcl/index.html

http://miles.ghostscript.com:8080/artifex/01a71ecbfe576d0a840946a0089f23ce131e995d/pcl-scan-build.txt