Re: [testdrivendevelopment] "I think the community needs more explicit direction...."

"Avi Kessner" <[email protected]> Mon, 25 Nov 2019 19:55:54 +0200
Newsgroups gmane.comp.programming.test-driven-development
Message-ID <CAGEhWpFzHBSe-yFK+j+TbxmXk75qsGBs8u7Lx-hdEeEvVzju0A@mail.gmail.com>
--0000000000005a762305982f7a83
Content-Type: text/plain; charset="UTF-8"

Why code review and not do pairing?

Not enough hours in the day.
I do code reviews on my phone, while waiting for my food to cook, etc.
Such is modern life.  The code I review is sometimes done in pairs.

I'm currently in the process of getting both senior and junior developers
to look at the existing code as "inspiration" to write easier to change
code, rather than a gold standard to mimic.

On Mon, Nov 25, 2019, 19:27 Steve Gordon <[email protected]> wrote:

> Wouldn't pairing with them work better than code reviews?  If not, why not?
>
> On Mon, Nov 25, 2019 at 10:16 AM Avi Kessner <[email protected]> wrote:
>
>> We hire a lot of developers straight out of school or working less than 3
>> years.
>>
>> From what I have seen, TDD is viewed as a skill used on Greenfield
>> projects, and refactoring is seen as something you do with legacy code.
>> (And still gets confused with 'throw it away and start over')
>>
>> I have to have more than one code review with them until it clicks that
>> you do both together, always.
>>
>> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#35778): https://groups.io/g/testdrivendevelopment/message/35778
Mute This Topic: https://groups.io/mt/61850834/3268755
Group Owner: [email protected]
Unsubscribe: https://groups.io/g/testdrivendevelopment/leave/6156322/744556386/xyzzy  [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


--0000000000005a762305982f7a83
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div dir=3D"auto"><br></div><div dir=3D"auto">Why code re=
view and not do pairing?</div><div dir=3D"auto"><br></div>Not enough hours =
in the day.<div dir=3D"auto">I do code reviews on my phone, while waiting f=
or my food to cook, etc.=C2=A0</div><div dir=3D"auto">Such is modern life.=
=C2=A0 The code I review is sometimes done in pairs.</div><div dir=3D"auto=
"><br></div><div dir=3D"auto">I&#39;m currently in the process of getting b=
oth senior and junior developers to look at the existing code as &quot;insp=
iration&quot; to write easier to change code, rather than a gold standard t=
o mimic.</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=
=3D"gmail_attr">On Mon, Nov 25, 2019, 19:27 Steve Gordon &lt;<a href=3D"ma=
ilto:[email protected]">[email protected]</a>&gt; wrote:<br></div><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #=
ccc solid;padding-left:1ex"><div dir=3D"ltr"><div>Wouldn&#39;t pairing with=
 them work better than code reviews?=C2=A0 If not, why not?</div><br><div c=
lass=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Nov 25, =
2019 at 10:16 AM Avi Kessner &lt;<a href=3D"mailto:[email protected]" targ=
et=3D"_blank" rel=3D"noreferrer">[email protected]</a>&gt; wrote:<br></div=
><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border=
-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"auto">We hir=
e a lot of developers straight out of school or working less than 3 years.<=
div dir=3D"auto"><br></div><div dir=3D"auto">From what I have seen, TDD is =
viewed as a skill used on Greenfield projects, and refactoring is seen as s=
omething you do with legacy code. (And still gets confused with &#39;throw =
it away and start over&#39;)</div><div dir=3D"auto"><br></div><div dir=3D"a=
uto">I have to have more than one code review with them until it clicks tha=
t you do both together, always.</div></div><div class=3D"gmail_quote"><div =
dir=3D"ltr" class=3D"gmail_attr"><br></div></div>

<p></p><p></p></blockquote></div></div>



</p></p></blockquote></div>

<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>
<hr>
Groups.io Links:<p>

You receive all messages sent to this group.


<p>

<a target=3D"_blank" href=3D"https://groups.io/g/testdrivendevelopment/mes=
sage/35778">View/Reply Online (#35778)</a> |


  <a target=3D"_blank" href=3D"mailto:[email protected]?subj=
ect=3DRe:%20Re%3A%20%5Btestdrivendevelopment%5D%20%22I%20think%20the%20comm=
unity%20needs%20more%20explicit%20direction....%22">Reply To Group</a>
  
    | <a target=3D"_blank" href=3D"mailto:[email protected]?subject=3DPri=
vate:%20Re:%20Re%3A%20%5Btestdrivendevelopment%5D%20%22I%20think%20the%20co=
mmunity%20needs%20more%20explicit%20direction....%22">Reply To Sender</a>
  


|


  
    <a target=3D"_blank" href=3D"https://groups.io/mt/61850834/3268755">Mu=
te This Topic</a>
  

| <a href=3D"https://groups.io/g/testdrivendevelopment/post">New Topic</a>=
<br>



<br>

<a href=3D"https://groups.io/g/testdrivendevelopment/editsub/3268755">Your=
 Subscription</a> |
<a href=3D"mailto:[email protected]">Contact Group Own=
er</a> |

<a href=3D"https://groups.io/g/testdrivendevelopment/leave/6156322/7445563=
86/xyzzy">Unsubscribe</a>

 [[email protected]]<br>
<div width=3D"1" style=3D"color:white;clear:both">_._,_._,_</div>


--0000000000005a762305982f7a83--