Re: Protecting master branch on GitHub?

Peter Cock <[email protected]> Thu, 26 Oct 2017 10:18:41 +0100
Newsgroups gmane.comp.python.bio.devel
Message-ID <CAKVJ-_5NOuZAGF5GpFK=boapYwrqQqFXN+bfz4_ha1bfoBjSeA@mail.gmail.com>
Hello all,

In practice the new branch protection works nicely
when the volume of pull request is low. However,
it seems that a side effect of the change is GitHub is
more insistent that the PR has been tested against
the latest master branch.

This makes dealing with merging multiple unrelated
pull requests one after the other much more painful -
as after the first merge the others need retesting.

I have in the short term allowed administrators to
override this, for example this pull request (where
I have included screenshots of the merge process):

https://github.com/biopython/biopython/pull/1426

If anyone has a deeper understanding of how GitHub
might be better configured that would be a plus.

Peter

On Thu, Sep 21, 2017 at 11:18 AM, Peter Cock <[email protected]> wrote:
> Thank you everyone - including the off list replies,
> master branch protections are now live!
>
> I have deliberately NOT required the codecov checks
> to pass - the test coverage numbers have proved far
> too noisy to use as a simple yes/no check.
>
> Also since there are two AppVeyor entries, I may
> not have ticked the right one(s) - but initially the
> setup is as follows (see below).
>
> Question for later: Should we go further and require
> a pull request be reviewed prior to merging? See also:
>
> http://mailman.open-bio.org/pipermail/biopython-dev/2017-September/021871.html
>
> Regards,
>
> Peter
>