Re: Protecting master branch on GitHub?

Thank you to Bjoern Gruening,

Based on how BioConda and Galaxy usage, he recommended unticking this setting:

> [ ] Require branches to be up to date before merging
>     This ensures the branch has been tested with the latest code on master.

That makes sense to me now - I hadn't appreciated the ramifications of
ticking this.

Peter


On Thu, Oct 26, 2017 at 10:18 AM, Peter Cock <[email protected]> wrote:
> Hello all,
>
> In practice the new branch protection works nicely
> when the volume of pull request is low. However,
> it seems that a side effect of the change is GitHub is
> more insistent that the PR has been tested against
> the latest master branch.
>
> This makes dealing with merging multiple unrelated
> pull requests one after the other much more painful -
> as after the first merge the others need retesting.
>
> I have in the short term allowed administrators to
> override this, for example this pull request (where
> I have included screenshots of the merge process):
>
> https://github.com/biopython/biopython/pull/1426
>
> If anyone has a deeper understanding of how GitHub
> might be better configured that would be a plus.
>
> Peter
>
> On Thu, Sep 21, 2017 at 11:18 AM, Peter Cock <[email protected]> wrote:
>> Thank you everyone - including the off list replies,
>> master branch protections are now live!
>>
>> I have deliberately NOT required the codecov checks
>> to pass - the test coverage numbers have proved far
>> too noisy to use as a simple yes/no check.
>>
>> Also since there are two AppVeyor entries, I may
>> not have ticked the right one(s) - but initially the
>> setup is as follows (see below).
>>
>> Question for later: Should we go further and require
>> a pull request be reviewed prior to merging? See also:
>>
>> http://mailman.open-bio.org/pipermail/biopython-dev/2017-September/021871.html
>>
>> Regards,
>>
>> Peter
>>