Re: PATCH: use GCC hidden visibility attribute

Federico Di Gregorio <fog-NGVKUo/i/[email protected]>
Newsgroups gmane.comp.python.db.psycopg.devel
Organization initd.org
Message-ID <[email protected]>
Il giorno lun, 21/01/2008 alle 11.42 +0900, James Henstridge ha scritto:
> Attached is a patch that makes psycopg use GCC's "hidden" visibility
> attribute on a bunch of symbols (provided it is compiled with GCC >=
> 4.0).
> 
> This does two things:
> 1. removes those symbols from the dynamic linking symbol table
> 2. simplifies references to those symbols inside _psycopg.so, since
> they no longer have to go through the GOT.
> 
> On my AMD64 box, here are before and after results from "size":
> 
>    text    data     bss     dec     hex filename
>  136450   16328     480  153258   256aa _psycopg.so
> 
>    text    data     bss     dec     hex filename
>  128882   15856     480  145218   23742 _psycopg.so
> 
> Which is about a 5% reduction in code size.

Seems fine to commit to me. 

federico

-- 
Federico Di Gregorio                         http://people.initd.org/fog
Debian GNU/Linux Developer                                [email protected]
INIT.D Developer                                           fog-NGVKUo/i/[email protected]
  Alla faccia della trasparenza! Ma che si fa, lo si prende e lo si
   mena? (In pubblico, per trasparenza.)                     -- <mrjive>

_______________________________________________
Psycopg mailing list
Psycopg-IAPFreCvJWPBWskQ1e/[email protected]
http://lists.initd.org/mailman/listinfo/psycopg
signature.asc (application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBHlGGyvcCgrgZGjesRAsKKAKCAmqSMBLGNtT+NjaozpBdDA8ixXQCfanTT
HxHogrieQkm6c721YyCy6dM=
=Ogn8
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.