Re: PATCH: cyclic GC traversal for psycopg types
Federico Di Gregorio <fog-NGVKUo/i/[email protected]>
| Newsgroups | gmane.comp.python.db.psycopg.devel |
|---|---|
| Organization | initd.org |
| Message-ID | <[email protected]> |
Il giorno mar, 22/07/2008 alle 17.49 +0800, James Henstridge ha scritto: > Attached is a patch to add cyclic GC traversal support to the > extension types that Psycopg defines. I have not implemented the > tp_clear method for any of the types so there can be cases where this > won't result in cycles being broken, but it should at least make them > visible to the GC (and related debugging tools). > > If we find cases where objects get involved in unbreakable cycles, we > can look at adding tp_clear implementations (which probably also > involves more extensive checking of the reference handling in said > classes). Seems fine to me. Do you want me to merge or will you just commit? federico -- Federico Di Gregorio http://people.initd.org/fog Debian GNU/Linux Developer [email protected] INIT.D Developer fog-NGVKUo/i/[email protected] Ma chi sei?....-il trafficante di Nutella? -- Giorgia _______________________________________________ Psycopg mailing list Psycopg-IAPFreCvJWPBWskQ1e/[email protected] http://lists.initd.org/mailman/listinfo/psycopg
signature.asc
(application/pgp-signature, 197 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkiG3/AACgkQvcCgrgZGjesBvACfWn1Zl17GVwEPTS6l5+M4RgAA Lh0An3m1VuxkDQPJvEXn61PB4XBpPy4m =Y1w/ -----END PGP SIGNATURE-----