Re: PATCH: cyclic GC traversal for psycopg types

On Wed, Jul 23, 2008 at 3:38 PM, Federico Di Gregorio <fog-NGVKUo/i/[email protected]> wrote:
> Il giorno mar, 22/07/2008 alle 17.49 +0800, James Henstridge ha scritto:
>> Attached is a patch to add cyclic GC traversal support to the
>> extension types that Psycopg defines.  I have not implemented the
>> tp_clear method for any of the types so there can be cases where this
>> won't result in cycles being broken, but it should at least make them
>> visible to the GC (and related debugging tools).
>>
>> If we find cases where objects get involved in unbreakable cycles, we
>> can look at adding tp_clear implementations (which probably also
>> involves more extensive checking of the reference handling in said
>> classes).
>
> Seems fine to me. Do you want me to merge or will you just commit?

Thanks, I've merged it now.  I just wanted to check if the change
looked reasonable.

James.