Feedback requested for new NumPy feature PR

--===============6621867028418421625==
Content-Type: multipart/alternative; boundary="00000000000020638d0655c8404b"

--00000000000020638d0655c8404b
Content-Type: text/plain; charset="UTF-8"

Hi everyone,

I recently opened a PR adding  support for an offset argument to diagonal
helper functions so they can operate on diagonals above or below the main
diagonal.
https://github.com/numpy/numpy/pull/31493

During the review, I was asked to send a quick note here to gather broader
feedback before the PR moves forward.

If anyone has concerns, suggestions, or feedback on the feature or API, I'd
be happy to hear them.

Thanks!
Ricardo Santos

--00000000000020638d0655c8404b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><p class=3D"gmail-isSelectedEnd">Hi everyone,</p><p class=
=3D"gmail-isSelectedEnd">I recently opened a PR adding=C2=A0 support for an=
 offset=C2=A0argument to diagonal helper functions=C2=A0so they can operate=
 on diagonals above or below the main diagonal.=C2=A0</p><a href=3D"https:/=
/github.com/numpy/numpy/pull/31493">https://github.com/numpy/numpy/pull/314=
93</a><br><p class=3D"gmail-isSelectedEnd">During the review, I was asked t=
o send a quick note here to gather broader feedback before the PR moves for=
ward.</p><p class=3D"gmail-isSelectedEnd">If anyone has concerns, suggestio=
ns, or feedback on the feature or API, I&#39;d be happy to hear them.</p><p=
>Thanks!<br>Ricardo Santos</p></div>

--00000000000020638d0655c8404b--

--===============6621867028418421625==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
NumPy-Discussion mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/numpy-discussion.python.org
Member address: [email protected]

--===============6621867028418421625==--