Re: Feedback requested for new NumPy feature PR

--===============4450359779281023744==
Content-Type: multipart/alternative; boundary="000000000000b768d30655dc24aa"

--000000000000b768d30655dc24aa
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Jul 5, 2026 at 6:11=E2=80=AFAM ricas28 via NumPy-Discussion <
[email protected]> wrote:

> Hi everyone,
>
> I recently opened a PR adding  support for an offset argument to diagonal
> helper functions so they can operate on diagonals above or below the main
> diagonal.
> https://github.com/numpy/numpy/pull/31493
>
> During the review, I was asked to send a quick note here to gather broade=
r
> feedback before the PR moves forward.
>
> If anyone has concerns, suggestions, or feedback on the feature or API,
> I'd be happy to hear them.
>

Probably worth linking to the issue, which has extra context and a link to
a prior mailing list post about this.

https://github.com/numpy/numpy/issues/28310



Thanks!
> Ricardo Santos
> _______________________________________________
> NumPy-Discussion mailing list -- [email protected]
> To unsubscribe send an email to [email protected]
> https://mail.python.org/mailman3//lists/numpy-discussion.python.org
> Member address: [email protected]
>

--000000000000b768d30655dc24aa
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">On Sun, Jul 5, 2026 at 6:11=E2=80=AFAM ricas28 via NumPy-=
Discussion &lt;<a href=3D"mailto:[email protected]">numpy-discuss=
[email protected]</a>&gt; wrote:<br></div><div><div class=3D"gmail_quote gmail=
_quote_container"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px=
 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div di=
r=3D"ltr"><p>Hi everyone,</p><p>I recently opened a PR adding=C2=A0 support=
 for an offset=C2=A0argument to diagonal helper functions=C2=A0so they can =
operate on diagonals above or below the main diagonal.=C2=A0</p><a href=3D"=
https://github.com/numpy/numpy/pull/31493" target=3D"_blank">https://github=
.com/numpy/numpy/pull/31493</a><br><p>During the review, I was asked to sen=
d a quick note here to gather broader feedback before the PR moves forward.=
</p><p>If anyone has concerns, suggestions, or feedback on the feature or A=
PI, I&#39;d be happy to hear them.</p></div></blockquote><div dir=3D"auto">=
<br></div><div dir=3D"auto"><div style=3D"font-size:inherit"><div dir=3D"au=
to" style=3D"font-size:inherit;font-style:normal;font-weight:400;letter-spa=
cing:normal;text-indent:0px;text-transform:none;white-space:normal;word-spa=
cing:0px;background-color:rgba(0,0,0,0);border-color:rgb(0,0,0);color:rgb(0=
,0,0)">Probably worth linking to the issue, which has extra context and a l=
ink to a prior mailing list post about this.</div><div dir=3D"auto" style=
=3D"font-size:inherit;font-style:normal;font-weight:400;letter-spacing:norm=
al;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;=
background-color:rgba(0,0,0,0);border-color:rgb(0,0,0);color:rgb(0,0,0)"><b=
r></div><div dir=3D"auto" style=3D"font-size:inherit;font-style:normal;font=
-weight:400;letter-spacing:normal;text-indent:0px;text-transform:none;white=
-space:normal;word-spacing:0px;background-color:rgba(0,0,0,0);border-color:=
rgb(0,0,0);color:rgb(0,0,0)"><div style=3D"font-size:inherit;background-col=
or:rgba(0,0,0,0);border-color:rgb(0,0,0);color:rgb(0,0,0)"><a href=3D"https=
://github.com/numpy/numpy/issues/28310" style=3D"font-size:inherit;backgrou=
nd-color:rgba(0,0,0,0);border-color:rgb(66,133,244);color:rgb(66,133,244)">=
https://github.com/numpy/numpy/issues/28310</a></div></div><br style=3D"fon=
t-size:inherit"></div><br></div><div dir=3D"auto"><br></div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><p dir=3D"auto"></p><p>=
Thanks!<br>Ricardo Santos</p></div>
_______________________________________________<br>
NumPy-Discussion mailing list -- <a href=3D"mailto:numpy-discussion@python.=
org" target=3D"_blank">[email protected]</a><br>
To unsubscribe send an email to <a href=3D"mailto:numpy-discussion-leave@py=
thon.org" target=3D"_blank">[email protected]</a><br>
<a href=3D"https://mail.python.org/mailman3//lists/numpy-discussion.python.=
org" rel=3D"noreferrer" target=3D"_blank">https://mail.python.org/mailman3/=
/lists/numpy-discussion.python.org</a><br>
Member address: <a href=3D"mailto:[email protected]" target=3D"_blank">=
[email protected]</a><br>
</blockquote></div></div>

--000000000000b768d30655dc24aa--

--===============4450359779281023744==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
NumPy-Discussion mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3//lists/numpy-discussion.python.org
Member address: [email protected]

--===============4450359779281023744==--