Re: merge script broken in Optik 1.5 (patches attached)

On 12 December 2004, Andrea 'fwyzard' Bocci said:
> Alas (I've ALWAYS wanted to say that :-), I've found out that the merge
> script is broken in Optik 1.5 (I have revision 473 from the repository).
> 
> 	./merge optik.py /dev/null
> 
> would create a non working module.

D'ohhh!  Thank you for spotting this.  Sorry about the delay -- December
was a bit busy with other things.

> 1.) merge vs. lib/option.py
[...]
> 2.) merge vs. lib/errors.py
[...]

I've checked in your two patches -- perfect.

> 3.) lib/option_parser.py vs. errors namespace
> This is slightly more complex to deal with:
> lib/option_parser.py uses lib/errors.py's exception classes directly
> from the "errors" namespace, ie.

Ooops -- I reverted to explicitly importing all the exceptions.  If I
had realized this would break the 'merge' script, I never would have
used qualified names!  So I'm ignoring your patch for this problem.

Also, I fixed the merge script so it takes full care of converting the
test script -- at last, I can generate optparse and test_optparse for
Python with one command.

These fixes will be in Optik 1.5.1 and Python 2.4.1.

        Greg


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt