Re: @robin: wishes
Kevin Ollivier <[email protected]>
| Newsgroups | gmane.comp.python.wxpython.devel |
|---|---|
| Message-ID | <[email protected]> |
> On Nov 10, 2015, at 9:42 AM, Dietmar Schwertberger <[email protected]> wrote: > > Am 10.11.2015 um 08:42 schrieb Werner: >> Could you comment on the PRs what additional work you think is needed. If the contributer agrees then he/she will make the changes and it is already a little less work for Robin. > Sure, I added my comment to the pull request #18 regarding Window build.py improvements. > This is a good example: the most pull requests are probably only validated in a single build environment on a single machine and I would assume that there's no buildbot which validates a pull request on all platforms. > > On the other hand, build.py is something which can be extended without too deep knowledge of wxPython, C++ and SIP. E.g. currently it's a bit monolithic. When I make a change to an etg file, each and everything is built again and when there's an error after some ten minutes, I don't see the original error message of e.g. the C compiler. > > > Also, when I want to contribute e.g. the MetafileDC as pull-request, I would still need some consulting before I can finalize a PR (see my question on -users). So, if the required consulting expertise is not present on -dev or -users, the number of contributions probably will stay low. As to your MetafileDC problem, I just saw the wxPython-users thread, did you try deleting metafile.sip and sip_corecmodule.cpp and rebuilding after you added the command to ignore wxMakeMetafilePlaceable? To me that problem sounds like it was not regenerating the files properly after the change. Regards, Kevin > > Regards, > > Dietmar > > -- > You received this message because you are subscribed to the Google Groups "wxPython-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "wxPython-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.