Re: Question about the ticket #743 omindex: delay libmagic checks

On 23 Apr 2017, at 17:22, YuLun Cai <[email protected]> wrote:

> I'd suggest to start with you just look at moving the libmagic check after
> the filesize checks, so you don't need to get into whether libmagic or
> the database check is cheaper on average.
> 
> hi, Olly, I have moved the libmagic check after the filesize check directly,
> 
> https://github.com/caiyulun/xapian/commit/3a97d9ee5397fa900a473aa9b3d8eeb720177a4e 
> 
> can you provide your comments on it and give some advice about the next steps?

Can you create a pull request from this? It provides easier tools for feeding back on proposed changes.

J

-- 
 James Aylett
 devfort.com — spacelog.org — tartarus.org/james/