Re: Question about the ticket #743 omindex: delay libmagic checks

Hi, James, I have created a PR https://github.com/xapian/xapian/pull/153
<https://github.com/xapian/xapian/pull/153>

looking forward to the response.

Thanks

2017-04-24 0:26 GMT+08:00 James Aylett <[email protected]>:

> On 23 Apr 2017, at 17:22, YuLun Cai <[email protected]> wrote:
>
> > I'd suggest to start with you just look at moving the libmagic check
> after
> > the filesize checks, so you don't need to get into whether libmagic or
> > the database check is cheaper on average.
> >
> > hi, Olly, I have moved the libmagic check after the filesize check
> directly,
> >
> > https://github.com/caiyulun/xapian/commit/3a97d9ee5397fa900a473aa9b3d8ee
> b720177a4e
> >
> > can you provide your comments on it and give some advice about the next
> steps?
>
> Can you create a pull request from this? It provides easier tools for
> feeding back on proposed changes.
>
> J
>
> --
>  James Aylett
>  devfort.com — spacelog.org — tartarus.org/james/
>
>